Version 5 problems.

[MMWebmaster]

(Taken from an e-mail sent to staff member)

Hello i've been using your DHTML Menu (version 5 i think) for awhile now... but i've come across errors.

First, a valid HTML (or any page) needs proper code, the code you issue out for clients... isn't proper. The code lacks type attibutes and isn't valid in any validation standards. I had to change these codes in order to make the site 100% valid (and this is only for a very basic validation). All still works and the link to your site still stands (as the free license states), unfortunately with this code (needed to make the site look proper in any browser) makes the menu faulty in certain browsers. To view the changes I made please view:

http://mm.intellstat.com

If you view this in Opera 7.54 or Netscape 7.2 you should notice a radical change in the appearance, such as font size increase and borders missing. IE6 still reads fine, I can't remember if either mozilla browser (mozilla 1.7 or firefox 0.9.1) had any errors. If there is a fix please notify me right away. I thought I would bring this to your attention so your services seem professional and already debugged for future clients.

Thank you for your time and use of the menu,
Sincerely,
The webmaster of Monthly Maintenance

[John]

First, a valid HTML (or any page) needs proper code, the code you issue out for clients... isn't proper.

Exactly what code are you talking about? Your statement is incomplete at best.

To view the changes I made please view:

Still doesn't tell me anything. No comments to show what you've done, nor any mention of exactly what errors you were getting (40???).

If you view this in Opera 7.54 or Netscape 7.2 you should notice a radical change in the appearance, such as font size increase and borders missing.

Perhaps partly, or more, due to the fact you are running code that is 22 versions down-level. Many changes/fixes/updates in that time. You're on 5.19, current is 5.41.

Also, some of your syntax in the _data file is incorrect, as can be seen in the sample _data file that comes in the download. Basically, all aI statements end in ;"); - as in the corrected...

Code: Select all

aI("text=Home;url=http://mm.intellstat.com/;separatorsize=1;");

Clean out the ;; items.

[MMWebmaster]

Hmm I noticed it said Version 5.41 and I tried to figure out what version I had but it's not listen anywhere, all the files just say 5.0 (even the new ones).

I'll download that and see what it does, and here are the changes:

----Original----

<SCRIPT language=JavaScript src="/menu/milonic_src.js" type=text/javascript></SCRIPT>

<script language=JavaScript>
if(ns4)_d.write("<scr"+"ipt language=JavaScript src=/menu/mmenuns4.js><\/scr"+"ipt>");
else _d.write("<scr"+"ipt language=JavaScript src=/menu/mmenudom.js><\/scr"+"ipt>");

</script>

<SCRIPT language=JavaScript src="/menu/menu_data.js" type=text/javascript></SCRIPT>

----End----

----"Perfect" to a validator-----

<script language="javascript" src="/menu/milonic_src.js" type="text/javascript"></script>

<script language="javascript" type="text/javascript">
if(ns4)_d.write("<scr"+"ipt language=JavaScript src=/menu/mmenuns4.js><\/scr"+"ipt>");
else _d.write("<scr"+"ipt language=JavaScript src=/menu/mmenudom.js><\/scr"+"ipt>");
</script>

<script language="javascript" src="/menu/menu_data.js" type="text/javascript"></script>

----End----

A lot of it was lack of script language or even what type it is, others are putting quotes around those things (i.e. "text/javascript"). Small things but I guess it can cause errors.

[John]

Hmm I noticed it said Version 5.41 and I tried to figure out what version I had but it's not listen anywhere, all the files just say 5.0 (even the new ones).

Check the second comment line of any of the 3 code files...

Code: Select all

Version 5.42 - Built: Thursday August 19 2004 - 11:14

As for the unquoted items, yes, everything should be quoted (especially with XHTML). There are some discussions about it on the board which a Search would have found. At any rate, it's on Andy's very long list of things to do.

[MMWebmaster]

I just got version 5.42 and now it's fully compatible with the validation and has no problem with the HTML Transitional 4.01 doctype (the older one did). Seems like it's been fixed already ^.^

One question, 5.42 didn't include this code, but I slipped it into the menu with no problem, i'm wondering if it's ok to do:

screenposition="center";

[John]

One question, 5.42 didn't include this code, but I slipped it into the menu with no problem, i'm wondering if it's ok to do:
screenposition="center";

I do not understand what you mean by "didn't include this code...".